Bug 252495 - Table-layout:fixed is not applied when width is max-content
Summary: Table-layout:fixed is not applied when width is max-content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tables (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BrowserCompat, InRadar, WPTImpact
Depends on:
Blocks:
 
Reported: 2023-02-17 10:39 PST by Ahmad Saleem
Modified: 2023-02-18 00:47 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-02-17 10:39:29 PST 
Hi Team,

While doing local testing by merging Blink PR, I came across quick win on WPT testcase:

Link - http://wpt.live/css/css-tables/fixed-layout-2.html

Blink Commit - https://chromium.googlesource.com/chromium/src/+/8353c86f025f1556fa9fd18b516751259d49a7cf

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/style/RenderStyle.h#502

Changing to this:

bool isFixedTableLayout() const { return tableLayout() == TableLayoutType::Fixed && (logicalWidth().isSpecified() || logicalWidth().isFitContent() || logicalWidth().isMinContent()); }

____

Going to do PR without tests, since we haven't imported CSS-Tables yet.

Thanks!
Comment 1 EWS 2023-02-18 00:46:20 PST 
Committed 260501@main (f4a3552fc9e6): <https://commits.webkit.org/260501@main>

Reviewed commits have been landed. Closing PR #10293 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2023-02-18 00:47:24 PST 
<rdar://problem/105627723>