Bug 252507 - [Multicolumn] Margins incorrectly accounted for before forced breaks
Summary: [Multicolumn] Margins incorrectly accounted for before forced breaks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-17 14:56 PST by Ahmad Saleem
Modified: 2023-02-18 06:26 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-02-17 14:56:13 PST 
Hi Team,

While going through Blink's commit, I came across another potential merge fixing bug in multicolumn.

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=188456

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBlockFlow.cpp#1710

Failing Test Case (in Safari 16.3 & STP163) - https://jsfiddle.net/7tnzdkc4/show & https://jsfiddle.net/Lmr9p1af/show

^ Tested locally and WebKit ToT passes them after this merge.

Raising this bug so I can do PR.

Thanks!
Comment 1 EWS 2023-02-18 06:25:25 PST 
Committed 260510@main (e75a5cd7e299): <https://commits.webkit.org/260510@main>

Reviewed commits have been landed. Closing PR #10307 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2023-02-18 06:26:17 PST 
<rdar://problem/105631038>