Bug 252558 - [GTK][WPE] UI process release log not shown
Summary: [GTK][WPE] UI process release log not shown
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2023-02-20 04:17 PST by Carlos Garcia Campos
Modified: 2023-02-21 02:39 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2023-02-20 04:17:03 PST 
The problem is that logLevelString() implementation in WebKit layer doesn't take RELEASE_LOG_DISABLED into account. Actually the implementation of logLevelString() in all layers does the same, getting th value of WEBKIT_DEBUG env var, but with a few differences. We can have a single implementation in WTF and use WTF::logLevelString() from WebCore and WebKit.
Comment 1 Carlos Garcia Campos 2023-02-20 04:19:20 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10358
Comment 2 EWS 2023-02-21 02:39:16 PST 
Committed 260601@main (173e3ebecf4f): <https://commits.webkit.org/260601@main>

Reviewed commits have been landed. Closing PR #10358 and removing active labels.