Bug 252588 - Import wpt 'loading' WPT Tests from upstream
Summary: Import wpt 'loading' WPT Tests from upstream
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-20 11:47 PST by Ahmad Saleem
Modified: 2023-09-26 12:40 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-02-20 11:47:51 PST 
Hi Team,

This is just a bug to try to import tests from WPT since I am working on patch, which will progress three of those tests.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-02-27 11:49:09 PST 
<rdar://problem/105987852>
Comment 2 Alexey Proskuryakov 2023-03-04 11:15:31 PST 
We usually import WPT tests when we are working on a particular fix or feature, not just to have more of them (the latter is actually undesirable, as they take a lot of time and effort to run).
Comment 3 Ahmad Saleem 2023-03-04 11:16:55 PST 
(In reply to Alexey Proskuryakov from comment #2)
> We usually import WPT tests when we are working on a particular fix or
> feature, not just to have more of them (the latter is actually undesirable,
> as they take a lot of time and effort to run).

Yes, I was working on CSSPreloader fix, which fixed one of the testcase from here and other two, I am trying to fix. While remaining three pass already.
Comment 4 Alexey Proskuryakov 2023-03-04 11:17:06 PST 
Sorry, I misread what you said - you are working on a fix too. Still, not sure if that warrants importing a whole directory of tests.
Comment 5 Ahmad Saleem 2023-09-26 12:40:59 PDT 
I manage to import /loading/ tests manually, I was working on and I am not working on /loading/early-hints/ folder, so I will close this bug and when needed, will create new to upstream remaining test cases.

As of STP179, we pass all tests in loading/ directory (except sub-directory /early-hints/).