WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
252593
Move RenderText::canUseSimplifiedTextMeasuring logic to TextUtil
https://bugs.webkit.org/show_bug.cgi?id=252593
Summary
Move RenderText::canUseSimplifiedTextMeasuring logic to TextUtil
alan
Reported
2023-02-20 12:04:05 PST
ssia
Attachments
Patch
(5.47 KB, patch)
2023-02-20 15:12 PST
,
alan
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(12.83 KB, patch)
2023-02-20 20:35 PST
,
alan
no flags
Details
Formatted Diff
Diff
Patch
(12.83 KB, patch)
2023-02-20 20:49 PST
,
alan
no flags
Details
Formatted Diff
Diff
Patch
(15.00 KB, patch)
2023-02-21 09:07 PST
,
alan
no flags
Details
Formatted Diff
Diff
[fast-cq]Patch
(16.11 KB, patch)
2023-02-22 07:05 PST
,
alan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
alan
Comment 1
2023-02-20 15:12:52 PST
Created
attachment 465095
[details]
Patch
alan
Comment 2
2023-02-20 20:35:32 PST
Created
attachment 465101
[details]
Patch
alan
Comment 3
2023-02-20 20:49:32 PST
Created
attachment 465102
[details]
Patch
Antti Koivisto
Comment 4
2023-02-21 07:05:47 PST
Comment on
attachment 465102
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=465102&action=review
> Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:199 > + auto canUseSimplifiedTextMeasuring = canUseSimpleFontCodePath ? Layout::TextUtil::canUseSimplifiedTextMeasuring(text, style, firstLineStyle.get()) : false;
canUseSimpleFontCodePath && Layout::TextUtil::canUseSimplifiedTextMeasuring(text, style, firstLineStyle.get()) is shorter.
alan
Comment 5
2023-02-21 09:07:32 PST
Created
attachment 465110
[details]
Patch
alan
Comment 6
2023-02-22 07:05:47 PST
Created
attachment 465119
[details]
[fast-cq]Patch
EWS
Comment 7
2023-02-22 07:19:16 PST
Committed
260675@main
(7d5263e5eaa4): <
https://commits.webkit.org/260675@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 465119
[details]
.
Radar WebKit Bug Importer
Comment 8
2023-02-22 07:20:23 PST
<
rdar://problem/105778355
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug