Bug 252593 - Move RenderText::canUseSimplifiedTextMeasuring logic to TextUtil
Summary: Move RenderText::canUseSimplifiedTextMeasuring logic to TextUtil
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-20 12:04 PST by zalan
Modified: 2023-02-22 07:20 PST (History)
12 users (show)

See Also:

Attachments
Patch (5.47 KB, patch)
2023-02-20 15:12 PST, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (12.83 KB, patch)
2023-02-20 20:35 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.83 KB, patch)
2023-02-20 20:49 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (15.00 KB, patch)
2023-02-21 09:07 PST, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (16.11 KB, patch)
2023-02-22 07:05 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-02-20 12:04:05 PST 
ssia
Comment 1 zalan 2023-02-20 15:12:52 PST 
Created attachment 465095 [details]
Patch
Comment 2 zalan 2023-02-20 20:35:32 PST 
Created attachment 465101 [details]
Patch
Comment 3 zalan 2023-02-20 20:49:32 PST 
Created attachment 465102 [details]
Patch
Comment 4 Antti Koivisto 2023-02-21 07:05:47 PST 
Comment on attachment 465102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465102&action=review

> Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:199
> +        auto canUseSimplifiedTextMeasuring = canUseSimpleFontCodePath ? Layout::TextUtil::canUseSimplifiedTextMeasuring(text, style, firstLineStyle.get()) : false;

canUseSimpleFontCodePath && Layout::TextUtil::canUseSimplifiedTextMeasuring(text, style, firstLineStyle.get())

is shorter.
Comment 5 zalan 2023-02-21 09:07:32 PST 
Created attachment 465110 [details]
Patch
Comment 6 zalan 2023-02-22 07:05:47 PST 
Created attachment 465119 [details]
[fast-cq]Patch
Comment 7 EWS 2023-02-22 07:19:16 PST 
Committed 260675@main (7d5263e5eaa4): <https://commits.webkit.org/260675@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465119 [details].
Comment 8 Radar WebKit Bug Importer 2023-02-22 07:20:23 PST 
<rdar://problem/105778355>