Bug 252612 - shrink CSSSelector
Summary: shrink CSSSelector
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-20 14:24 PST by Cameron McCormack (:heycam)
Modified: 2023-02-20 14:26 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2023-02-20 14:24:21 PST 
On 64 bit, CSSSelector is currently 16 bytes.  By moving some of its data to the rare data object, we can pack the remaining bits with the data union to shrink it to 8 bytes.  CSSSelector is a frequently allocated object, so this should have noticeable memory savings.
Comment 1 Radar WebKit Bug Importer 2023-02-20 14:24:38 PST 
<rdar://problem/105696499>
Comment 2 Cameron McCormack (:heycam) 2023-02-20 14:26:47 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10397