Bug 252617 - LLIntAssembly.h:38532:23: error: ‘g_superSamplerCount’ was not declared in this scope
Summary: LLIntAssembly.h:38532:23: error: ‘g_superSamplerCount’ was not declared in th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords: InRadar
: 252634 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-02-20 14:47 PST by Michael Catanzaro
Modified: 2023-02-20 19:43 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2023-02-20 14:47:09 PST 
WebKitGTK 2.39.90 fails to build on i686. It seems to be a JSC bug:

        In file included from /buildstream/gnome/sdk/webkitgtk-6.0.bst/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:432:
        /buildstream/gnome/sdk/webkitgtk-6.0.bst/_builddir/JavaScriptCore/DerivedSources/LLIntAssembly.h: In static member function ‘static JSC::JSValue JSC::LLInt::CLoop::execute(JSC::OpcodeID, void*, JSC::VM*, JSC::ProtoCallFrame*, bool)’:
        /buildstream/gnome/sdk/webkitgtk-6.0.bst/_builddir/JavaScriptCore/DerivedSources/LLIntAssembly.h:38532:23: error: ‘g_superSamplerCount’ was not declared in this scope
        38532 |     t1 = CAST<void*>(&g_superSamplerCount);                  // LowLevelInterpreter.asm:410
              |                       ^~~~~~~~~~~~~~~~~~~

I think this is just a simple case of missing #include "SuperSampler.h" in LowLevelInterpreter.cpp and will submit a pull request (likely tomorrow) if so.
Comment 1 Michael Catanzaro 2023-02-20 18:33:49 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10417
Comment 2 Michael Catanzaro 2023-02-20 19:01:32 PST 
*** Bug 252634 has been marked as a duplicate of this bug. ***
Comment 3 EWS 2023-02-20 19:42:20 PST 
Committed 260584@main (f51987a0f316): <https://commits.webkit.org/260584@main>

Reviewed commits have been landed. Closing PR #10417 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2023-02-20 19:43:20 PST 
<rdar://problem/105708925>