Bug 252629 - REGRESSION(260471@main): The platform graphics context colorspace should not be adopted
Summary: REGRESSION(260471@main): The platform graphics context colorspace should not ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-20 16:03 PST by Said Abou-Hallawa
Modified: 2023-02-23 13:37 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-02-20 16:03:10 PST 
When storing the return raw pointer of CGIOSurfaceContextGetColorSpace() or CGBitmapContextGetColorSpace() in a RetainPtr, we should not be using adoptCF(). The RetainPtr refcount should be incremented if the colorspace is referenced in WebKit.
Comment 1 Said Abou-Hallawa 2023-02-20 16:03:51 PST 
rdar://105637444
Comment 2 Said Abou-Hallawa 2023-02-20 16:47:14 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10413
Comment 3 EWS 2023-02-21 07:21:30 PST 
Committed 260609@main (fab6d531c24f): <https://commits.webkit.org/260609@main>

Reviewed commits have been landed. Closing PR #10413 and removing active labels.