Bug 252651 - Don't initialize signal handing machinery if we're not going to use it.
Summary: Don't initialize signal handing machinery if we're not going to use it.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-20 22:40 PST by Mark Lam
Modified: 2023-02-21 14:03 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2023-02-20 22:40:19 PST 
This saves some memory when the signal handling machinery is not needed.
Comment 1 Radar WebKit Bug Importer 2023-02-20 22:40:51 PST 
<rdar://problem/105712893>
Comment 2 Mark Lam 2023-02-20 23:02:41 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10431
Comment 3 EWS 2023-02-21 12:16:40 PST 
Committed 260623@main (0051847d2a39): <https://commits.webkit.org/260623@main>

Reviewed commits have been landed. Closing PR #10431 and removing active labels.
Comment 4 Fujii Hironori 2023-02-21 13:43:43 PST 
WinCairo gets broken. 
https://ews-build.webkit.org/#/builders/12/builds/118124
> C:\BW\WinCairo-EWS\build\Source\JavaScriptCore\runtime/InitializeThreading.cpp(124): error C3861: 'initializeSignalHandling': identifier not found
> C:\BW\WinCairo-EWS\build\Source\JavaScriptCore\runtime/InitializeThreading.cpp(131): error C3861: 'disableSignalHandling': identifier not found
Comment 5 Mark Lam 2023-02-21 14:03:43 PST 
(In reply to Fujii Hironori from comment #4)
> WinCairo gets broken. 
> https://ews-build.webkit.org/#/builders/12/builds/118124
> > C:\BW\WinCairo-EWS\build\Source\JavaScriptCore\runtime/InitializeThreading.cpp(124): error C3861: 'initializeSignalHandling': identifier not found
> > C:\BW\WinCairo-EWS\build\Source\JavaScriptCore\runtime/InitializeThreading.cpp(131): error C3861: 'disableSignalHandling': identifier not found

WinCairo build fix in https://bugs.webkit.org/show_bug.cgi?id=252688.