RESOLVED FIXED252670
[GTK] [2.39.90] Fails to build in armel: is_always_lock_free assertion failed 
https://bugs.webkit.org/show_bug.cgi?id=252670
Summary [GTK] [2.39.90] Fails to build in armel: is_always_lock_free assertion failed
Alberto Garcia
Reported 2023-02-21 09:20:08 PST
What the description says: ---------------------------------------- In file included from Source/ThirdParty/ANGLE/src/libANGLE/RefCountObject.h:20, from Source/ThirdParty/ANGLE/src/libANGLE/angletypes.h:19, from Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/BlitGL.h:15, from Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/BlitGL.cpp:9: Source/ThirdParty/ANGLE/src/libANGLE/renderer/serial_utils.h:132:37: error: static assertion failed: Must always be lock free 132 | static_assert(decltype(mValue)::is_always_lock_free, "Must always be lock free"); | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~ ---------------------------------------- The upstream change in ANGLE is this one: https://github.com/google/angle/commit/ce8ce6f81eff8a84e2ea59930cb995b1107181e2 From what I understand this was already broken, it's just that now it fails at build time.
Attachments
Add attachment proposed patch, testcase, etc.
Thomas Devoogdt
Comment 1 2024-03-29 05:50:57 PDT
Hi, I saw the same, and filled an upstream bug report: https://bugs.chromium.org/p/angleproject/issues/detail?id=8635 Kr, Thomas Devoogdt
Alberto Garcia
Comment 2 2024-04-02 05:09:18 PDT
Thanks, it seems to have been fixed there: https://chromium.googlesource.com/angle/angle/+/321c6b63bebce3f31414d8a53fb2f94b5561b818%5E!/
Alberto Garcia
Comment 3 2024-04-02 07:16:29 PDT
I confirm that WebKitGTK 2.44.0 builds with that patch
Thomas Devoogdt
Comment 4 2024-04-02 11:27:51 PDT
Hi, I opened a PR to main https://github.com/WebKit/WebKit/pull/26645. Kr, Thomas
Michael Catanzaro
Comment 5 2024-04-02 12:03:26 PDT
Fixed in 2.44. I see it's also fixed upstream and we should have many ANGLE updates prior to 2.46, so closing.
Note You need to log in before you can comment on or make changes to this bug.