Bug 252683 - [WPE] Turn off ENABLE_OPENTYPE_MATH
Summary: [WPE] Turn off ENABLE_OPENTYPE_MATH
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-21 12:51 PST by Michael Catanzaro
Modified: 2023-02-21 17:10 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2023-02-21 12:51:40 PST 
ENABLE_OPENTYPE_MATH is confusing. There are two implementations for parsing the OpenType MATH table:

 * WebKit internal implementation, used by WPE, Apple, Windows ports
 * harfbuzz implementation, added in 181910@main, used by GTK

I doubt there's any good reason for WPE and GTK ports to be different, so WPE should probably use harfbuzz?
Comment 1 Michael Catanzaro 2023-02-21 12:54:40 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10461
Comment 2 Frédéric Wang (:fredw) 2023-02-21 12:56:26 PST 
Yes, on ports where HarfBuzz is available we should use HarfBuzz's implementation.
Comment 3 EWS 2023-02-21 17:10:29 PST 
Committed 260641@main (0880ca8024e1): <https://commits.webkit.org/260641@main>

Reviewed commits have been landed. Closing PR #10461 and removing active labels.