Bug 252723 - [GPU Process][FormControls] Don't create a fake NSView if viewless cell drawing is supported
Summary: [GPU Process][FormControls] Don't create a fake NSView if viewless cell drawi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 249168
  Show dependency tree / graph
 
Reported: 2023-02-21 21:50 PST by Said Abou-Hallawa
Modified: 2023-02-22 21:54 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-02-21 21:50:25 PST 
For viewless drawing, we should not create the NSView. If we attempt to create an NSView while drawing a control part in GPU Process, that may throw an exception because creating an NSView or its NSWindow should happen only on the main thread.
Comment 1 Radar WebKit Bug Importer 2023-02-21 21:52:59 PST 
<rdar://problem/105762717>
Comment 2 Said Abou-Hallawa 2023-02-22 09:17:09 PST 
rdar://105778966
Comment 3 Said Abou-Hallawa 2023-02-22 11:04:09 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10528
Comment 4 EWS 2023-02-22 21:54:34 PST 
Committed 260726@main (d9b43d246262): <https://commits.webkit.org/260726@main>

Reviewed commits have been landed. Closing PR #10528 and removing active labels.