Bug 252806 - [web-animations] rewrite tests under LayoutTests/webanimations to use promise_test instead of async_test
Summary: [web-animations] rewrite tests under LayoutTests/webanimations to use promise...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-23 02:11 PST by Antoine Quint
Modified: 2023-02-23 12:06 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2023-02-23 02:11:00 PST 
We should stay clear of async_test which will cause timeouts in case of assertion failures while promise_test just ends the test.
Comment 1 Antoine Quint 2023-02-23 02:13:14 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10570
Comment 2 EWS 2023-02-23 12:04:53 PST 
Committed 260758@main (08509e730a88): <https://commits.webkit.org/260758@main>

Reviewed commits have been landed. Closing PR #10570 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-02-23 12:06:21 PST 
<rdar://problem/105845475>