WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
252834
Don't let intrinsic padding skew pagination struts on table cells
https://bugs.webkit.org/show_bug.cgi?id=252834
Summary
Don't let intrinsic padding skew pagination struts on table cells
Ahmad Saleem
Reported
2023-02-23 09:07:13 PST
Hi Team, While going through Blink's commit, I came across another one where were were failing test case: Test Case -
https://jsfiddle.net/n9fuxpch/show
Blink Commit -
https://chromium.googlesource.com/chromium/src.git/+/eacb4f4eb2e61cc6febe80fe23eb44eba2bde8e8
^ We don't match with Expected of this result while Chrome Canary 112 does. WebKit Source -
https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderTableRow.cpp#151
____ clearIntrinsicPadding(); but I am not sure about 'CellChildrenNeedLayout' but just wanted to raise so we can track this failure. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-03-02 09:08:14 PST
<
rdar://problem/106148471
>
Ahmad Saleem
Comment 2
2023-03-02 17:23:34 PST
Figured out: if (cell->cellWidthChanged()) cell->clearIntrinsicPadding(); ____ It leads to Safari match print output in following with Chrome Canary 112 but seems to be broken behavior IMO: Test Case -
https://jsfiddle.net/m0vwngk2/show
Do we need to fix this? Would appreciate any input. Thanks!
Ahmad Saleem
Comment 3
2024-06-28 16:17:46 PDT
PR attempt -
https://github.com/WebKit/WebKit/pull/12391
Test Locally on WebKit TOT - now it passes both test, might do PR again.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug