RESOLVED FIXED252898
Fix Compile error: 'bool std::isinf(float)' is not 'constexpr' with GCC 4.6 in C++11 mode 
https://bugs.webkit.org/show_bug.cgi?id=252898
Summary Fix Compile error: 'bool std::isinf(float)' is not 'constexpr' with GCC 4.6 i...
Seija K.
Reported 2023-02-24 06:34:38 PST
GCC is not used to compile Objective-C anymore, and GCC now supports std::max() inside a constexpr function.
Attachments
Add attachment proposed patch, testcase, etc.
Seija K.
Comment 1 2023-02-24 06:36:47 PST
Pull request: https://github.com/WebKit/WebKit/pull/10626
EWS
Comment 2 2023-02-27 07:06:24 PST
Committed 260883@main (d139619c4a1e): <https://commits.webkit.org/260883@main> Reviewed commits have been landed. Closing PR #10626 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-02-27 07:07:19 PST
<rdar://problem/105974095>
Diego Pino
Comment 4 2023-02-27 12:27:38 PST
This patch has broken Ubuntu 20.04 post-commit build bot (which uses GCC9.4 and we need to maintain until 20th April 2023): https://build.webkit.org/#/builders/595/builds/7860 ``` In file included from /home/buildbot/worker/GTK-Linux-64-bit-Release-Ubuntu-2004-Build/build/Source/WebCore/PAL/pal/text/TextCodecSingleByte.cpp:30: /usr/include/c++/9/mutex:666:5: error: ‘void std::call_once(std::once_flag&, _Callable&&, _Args&& ...) [with _Callable = PAL::tableForEncoding() [with const SingleByteDecodeTable& decodeTable = PAL::iso88593; PAL::SingleByteEncodeTable = WTF::IteratorRange<const std::pair<char16_t, unsigned char>*>]::<lambda()>; _Args = {}]’, declared using local type ‘PAL::tableForEncoding() [with const SingleByteDecodeTable& decodeTable = PAL::iso88593; PAL::SingleByteEncodeTable = WTF::IteratorRange<const std::pair<char16_t, unsigned char>*>]::<lambda()>’, is used but never defined [-fpermissive] 666 | call_once(once_flag& __once, _Callable&& __f, _Args&&... __args) | ^~~~~~~~~ ```
Diego Pino
Comment 5 2023-02-27 13:07:09 PST
Follow-up pull request: https://github.com/WebKit/WebKit/pull/10752 Restores changes in Source/WebCore/PAL/pal/text/TextCodecSingleByte.cpp.
Note You need to log in before you can comment on or make changes to this bug.