Bug 252975 - [margin-trim] shouldChildInlineMarginContributeToContainerIntrinsicSize should take into consideration text
Summary: [margin-trim] shouldChildInlineMarginContributeToContainerIntrinsicSize shoul...
Status: RESOLVED DUPLICATE of bug 253165
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-26 21:13 PST by Sammy Gill
Modified: 2023-03-06 09:45 PST (History)
4 users (show)

See Also:

Attachments
Testcase (470 bytes, text/html)
2023-02-26 21:13 PST, Sammy Gill 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2023-02-26 21:13:08 PST 
Created attachment 465194 [details]
Testcase

The attached test case shows how text can end up in a RenderBlockFlow. Currently shouldChildInlineMarginContributeToContainerIntrinsicSize is unable to handle such a case since it takes a RenderElement
Comment 1 Radar WebKit Bug Importer 2023-03-05 21:14:15 PST 
<rdar://problem/106271482>
Comment 2 Sammy Gill 2023-03-06 09:45:46 PST 
There better option here was to maintain the function signature as is since it makes more sense and then check the value we are trying to pass in at the call site.

*** This bug has been marked as a duplicate of bug 253165 ***