Bug 252992 - WARNING_CFLAGS should use $(inherited) instead of $(WK_COMMON_WARNING_CFLAGS)
Summary: WARNING_CFLAGS should use $(inherited) instead of $(WK_COMMON_WARNING_CFLAGS)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-27 07:55 PST by David Kilzer (:ddkilzer)
Modified: 2023-02-27 12:51 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2023-02-27 07:55:23 PST 
WARNING_CFLAGS should use $(inherited) instead of $(WK_COMMON_WARNING_CFLAGS).

Now that XCBuild is enabled for WebKit, we can simply switch to using $(inherited).

This addresses the FIXME in Configurations/CommonBase.xcconfig as well.
Comment 1 Radar WebKit Bug Importer 2023-02-27 07:55:50 PST 
<rdar://problem/105975565>
Comment 2 David Kilzer (:ddkilzer) 2023-02-27 07:59:01 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10727
Comment 3 EWS 2023-02-27 12:50:57 PST 
Committed 260902@main (3dafcdaa89c0): <https://commits.webkit.org/260902@main>

Reviewed commits have been landed. Closing PR #10727 and removing active labels.