RESOLVED FIXED253141
[CMake] Wayland scanner uses deprecated "code" parameter 
https://bugs.webkit.org/show_bug.cgi?id=253141
Summary [CMake] Wayland scanner uses deprecated "code" parameter
Adrian Perez
Reported 2023-03-01 01:29:52 PST
When building the WPE port, the following warnings are shown by wayland-scanner: [1874/12858] Generating ../../../WPEToolingBackends/DerivedSources/xdg-shell-protocol.c Using "code" is deprecated - use private-code or public-code. See the help page for details. [1875/12858] Generating ../../../WPEToolingBackends/DerivedSources/xdg-shell-unstable-v6-protocol.c Using "code" is deprecated - use private-code or public-code. See the help page for details. These warnings were introduced in Wayland 1.15.0, we should be using "private-code" instead (like the GTK port does). Debian 10 has version 1.17, and Ubuntu 20.04 LTS has version 1.20; therefore we can require version >=1.15—no need for using one parameter or the other depending on the version.
Attachments
Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2023-03-01 01:32:15 PST
The requirement by both the GTK and WPE ports is currently: find_package(Wayland REQUIRED) find_package(WaylandProtocols 1.12 REQUIRED) Let's take advantage of this issue to bump the requirement to 1.15 :)
Adrian Perez
Comment 2 2023-03-01 01:48:43 PST
Pull request: https://github.com/WebKit/WebKit/pull/10852
EWS
Comment 3 2023-03-01 05:52:57 PST
Committed 261001@main (05993ae119d4): <https://commits.webkit.org/261001@main> Reviewed commits have been landed. Closing PR #10852 and removing active labels.
Radar WebKit Bug Importer
Comment 4 2023-03-01 05:53:23 PST
<rdar://problem/106083063>
Note You need to log in before you can comment on or make changes to this bug.