Bug 253146 - [GTK][WPE] WebKitDownload destination should be a path instead of a URI
Summary: [GTK][WPE] WebKitDownload destination should be a path instead of a URI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords: Gtk
Depends on:
Blocks: 238748
  Show dependency tree / graph
 
Reported: 2023-03-01 03:07 PST by Carlos Garcia Campos
Modified: 2023-03-01 16:02 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2023-03-01 03:07:12 PST 
Destination is handled as a patch internally, so using URIs in the API means we have to convert to/from URI all the time. We can't change this in the current API, but for simplicity we can allow passing a paths, while still support uris for backwards compatibility. WebKiDownload::created-destination always returns a URI in the old API for compatibilty, but webkit_download_get_destination() only returns a URI when a URI was set with webkit_download_set_destination().
Comment 1 Carlos Garcia Campos 2023-03-01 03:10:46 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10855
Comment 2 EWS 2023-03-01 06:22:48 PST 
Committed 261002@main (6fea66849a84): <https://commits.webkit.org/261002@main>

Reviewed commits have been landed. Closing PR #10855 and removing active labels.
Comment 3 Michael Catanzaro 2023-03-01 15:54:48 PST 
We both forgot to update MiniBrowser. Fix in bug #253202
Comment 4 Michael Catanzaro 2023-03-01 16:02:18 PST 
(In reply to Michael Catanzaro from comment #3)
> We both forgot to update MiniBrowser. Fix in bug #253202

Just kidding. It intentionally does not support downloads yet.