Bug 253202 - [GTK] MiniBrowser needs updated for various downloads changes
Summary: [GTK] MiniBrowser needs updated for various downloads changes
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-01 15:47 PST by Michael Catanzaro
Modified: 2023-03-01 16:01 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2023-03-01 15:47:13 PST 
In 261002@main we forgot to update a call to webkit_download_get_destination() in MiniBrowser that expects to receive a URI but now receives a path.

Due to this, I noticed that the downloads code is currently unreachable due to a missing g_signal_connect() now that download-started moved from WebKitWebContext to WebKitNetworkSession. Let's fix that too.
Comment 1 Michael Catanzaro 2023-03-01 16:01:52 PST 
Actually this was a false alarm, because all of this code is built only for GTK 3. Downloads just are not hooked up yet at all.