Bug 253235 - run-jsc-stress-tests should generate data test descriptions, not mixed code/data
Summary: run-jsc-stress-tests should generate data test descriptions, not mixed code/data
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Angelos Oikonomopoulos
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-02 04:23 PST by Angelos Oikonomopoulos
Modified: 2023-03-09 04:24 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Angelos Oikonomopoulos 2023-03-02 04:23:10 PST 
Mixing code and data in the generated test_script_NNNN files has significant disadvantages:
- makes it unreasonably hard to ensure that changes to the run* functions in run-jsc-stress-tests have the desired effect (and only the desired effect)
- the generated file is hard to follow for humans
- extracting the command to run needs a significant number of mouse/keyboard actions
- automatically extracting the command is even harder, making it difficult to write wrappers.
Comment 1 Angelos Oikonomopoulos 2023-03-02 04:29:29 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10931
Comment 2 Radar WebKit Bug Importer 2023-03-09 04:24:18 PST 
<rdar://problem/106495046>