Bug 253286 - Fix F32/F64Copysign on Intel in single-pass BBQ JIT
Summary: Fix F32/F64Copysign on Intel in single-pass BBQ JIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Degazio
URL:
Keywords: InRadar
Depends on:
Blocks: 252209
  Show dependency tree / graph
 
Reported: 2023-03-02 17:47 PST by David Degazio
Modified: 2023-03-02 19:56 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Degazio 2023-03-02 17:47:31 PST 
rdar://106173548

The implementations for F32 and F64 copying on Intel move a mask into the result register, then AND it with the left operand register. If the result and left operand registers are the same, then this clobbers the left operand with the immediate, producing an incorrect answer.
Comment 1 David Degazio 2023-03-02 18:17:09 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10980
Comment 2 EWS 2023-03-02 19:56:40 PST 
Committed 261116@main (0cb9c0e04c8f): <https://commits.webkit.org/261116@main>

Reviewed commits have been landed. Closing PR #10980 and removing active labels.