Bug 253287 - AX: Enable XCTests to run in isolated tree mode.
Summary: AX: Enable XCTests to run in isolated tree mode.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-02 18:06 PST by Andres Gonzalez
Modified: 2023-03-03 11:57 PST (History)
11 users (show)

See Also:

Attachments
Patch (1.23 KB, patch)
2023-03-02 18:10 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2023-03-02 18:06:21 PST 
At the moment XCTests only run in Non-ITM.
Comment 1 Radar WebKit Bug Importer 2023-03-02 18:07:08 PST 
<rdar://problem/106174406>
Comment 2 Andres Gonzalez 2023-03-02 18:10:31 PST 
Created attachment 465270 [details]
Patch
Comment 3 Tyler Wilcock 2023-03-02 18:45:34 PST 
Comment on attachment 465270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465270&action=review

> Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:666
> +        || client == kAXClientTypeXCTest);

Should this have UNLIKELY to help the branch predictor?
Comment 4 Andres Gonzalez 2023-03-02 18:57:46 PST 
(In reply to Tyler Wilcock from comment #3)
> Comment on attachment 465270 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=465270&action=review
> 
> > Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:666
> > +        || client == kAXClientTypeXCTest);
> 
> Should this have UNLIKELY to help the branch predictor?

It does, UNLIKELY(...) encompasses WebKitTesting || SCTest.
Comment 5 Tyler Wilcock 2023-03-02 18:58:46 PST 
(In reply to Andres Gonzalez from comment #4)
> (In reply to Tyler Wilcock from comment #3)
> > Comment on attachment 465270 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=465270&action=review
> > 
> > > Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:666
> > > +        || client == kAXClientTypeXCTest);
> > 
> > Should this have UNLIKELY to help the branch predictor?
> 
> It does, UNLIKELY(...) encompasses WebKitTesting || SCTest.
Oops! Sorry.
Comment 6 EWS 2023-03-03 11:57:45 PST 
Committed 261159@main (2ab27dd5700e): <https://commits.webkit.org/261159@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465270 [details].