RESOLVED FIXED253287
AX: Enable XCTests to run in isolated tree mode. 
https://bugs.webkit.org/show_bug.cgi?id=253287
Summary AX: Enable XCTests to run in isolated tree mode.
Andres Gonzalez
Reported 2023-03-02 18:06:21 PST
At the moment XCTests only run in Non-ITM.
Attachments
Patch (1.23 KB, patch)
2023-03-02 18:10 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-03-02 18:07:08 PST
<rdar://problem/106174406>
Andres Gonzalez
Comment 2 2023-03-02 18:10:31 PST
Created attachment 465270 [details] Patch
Tyler Wilcock
Comment 3 2023-03-02 18:45:34 PST
Comment on attachment 465270 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=465270&action=review > Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:666 > + || client == kAXClientTypeXCTest); Should this have UNLIKELY to help the branch predictor?
Andres Gonzalez
Comment 4 2023-03-02 18:57:46 PST
(In reply to Tyler Wilcock from comment #3) > Comment on attachment 465270 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=465270&action=review > > > Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:666 > > + || client == kAXClientTypeXCTest); > > Should this have UNLIKELY to help the branch predictor? It does, UNLIKELY(...) encompasses WebKitTesting || SCTest.
Tyler Wilcock
Comment 5 2023-03-02 18:58:46 PST
(In reply to Andres Gonzalez from comment #4) > (In reply to Tyler Wilcock from comment #3) > > Comment on attachment 465270 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=465270&action=review > > > > > Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:666 > > > + || client == kAXClientTypeXCTest); > > > > Should this have UNLIKELY to help the branch predictor? > > It does, UNLIKELY(...) encompasses WebKitTesting || SCTest. Oops! Sorry.
EWS
Comment 6 2023-03-03 11:57:45 PST
Committed 261159@main (2ab27dd5700e): <https://commits.webkit.org/261159@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465270 [details].
Note You need to log in before you can comment on or make changes to this bug.