Bug 253373 - AX: Standalone spin buttons should be directly incrementable and decrementable
Summary: AX: Standalone spin buttons should be directly incrementable and decrementable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-03 19:46 PST by Tyler Wilcock
Modified: 2023-03-08 19:37 PST (History)
10 users (show)

See Also:


Attachments
Patch (18.62 KB, patch)
2023-03-03 20:00 PST, Tyler Wilcock
no flags Details | Formatted Diff | Diff
Patch (18.34 KB, patch)
2023-03-04 11:34 PST, Tyler Wilcock
no flags Details | Formatted Diff | Diff
Patch (18.33 KB, patch)
2023-03-07 18:13 PST, Tyler Wilcock
no flags Details | Formatted Diff | Diff
Patch (18.32 KB, patch)
2023-03-07 18:16 PST, Tyler Wilcock
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2023-03-03 19:46:24 PST
Standalone spin buttons should be directly incrementable and decrementable.
Comment 1 Radar WebKit Bug Importer 2023-03-03 19:46:36 PST
<rdar://problem/106224266>
Comment 2 Tyler Wilcock 2023-03-03 20:00:31 PST
Created attachment 465288 [details]
Patch
Comment 3 Tyler Wilcock 2023-03-04 11:34:19 PST
Created attachment 465293 [details]
Patch
Comment 4 Andres Gonzalez 2023-03-06 08:38:12 PST
(In reply to Tyler Wilcock from comment #3)
> Created attachment 465293 [details]
> Patch

Concerning the naming, can we use something like "simple" vs. "composite" instead of IncrementDecrement?

Could we expose all spinbuttons as "simple"? i.e., why do we need to expose the separate increment and decrement buttons?
Comment 5 Tyler Wilcock 2023-03-07 18:12:20 PST
(In reply to Andres Gonzalez from comment #4)
> (In reply to Tyler Wilcock from comment #3)
> > Created attachment 465293 [details]
> > Patch
> 
> Concerning the naming, can we use something like "simple" vs. "composite"
> instead of IncrementDecrement?
Composite is a good name, thanks. I think I like "standalone" over "simple" as it's more descriptive and a better analogy to "composite".

> Could we expose all spinbuttons as "simple"? i.e., why do we need to expose
> the separate increment and decrement buttons?
VoiceOver would handle the removal of these separate increment and decrement buttons just fine as long as the spinbutton itself exposes the increment and decrement actions. However, AppKit accessibility may expect attributes to be exposed for these separate spinbutton controls. I think we should explore whether we really need these attributes in a future patch.
Comment 6 Tyler Wilcock 2023-03-07 18:13:33 PST
Created attachment 465351 [details]
Patch
Comment 7 Tyler Wilcock 2023-03-07 18:16:13 PST
Created attachment 465353 [details]
Patch
Comment 8 EWS 2023-03-08 19:37:16 PST
Committed 261396@main (71206def1a57): <https://commits.webkit.org/261396@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465353 [details].