Bug 253388 - REGRESSION (261182@main): TestWebKitAPI.ProcessSwap.LockdownModeEnabledByDefaultThenOptOut and TestWebKitAPI.ProcessSwap.NavigatingToLockdownMode are failing
Summary: REGRESSION (261182@main): TestWebKitAPI.ProcessSwap.LockdownModeEnabledByDefa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-04 09:32 PST by Ryan Haddad
Modified: 2023-03-04 14:42 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2023-03-04 09:32:26 PST 
The following two tests are consistently failing after https://commits.webkit.org/261182@main

    TestWebKitAPI.ProcessSwap.LockdownModeEnabledByDefaultThenOptOut
        ERROR: Error while launching com.apple.WebKit.Networking: Connection invalid
        /Volumes/Data/worker/Apple-Ventura-Debug-Build/build/Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm(213) : auto WebKit::ProcessLauncher::launchProcess()::(anonymous class)::operator()(xpc_object_t) const
        LEAK: 2 WebProcessPool
        
        /Volumes/Data/worker/Apple-Ventura-Debug-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:7913
        Expected equality of these values:
          runJSCheck("!!window.CSSCounterStyleRule"_s)
            Which is: true
          shouldBeEnabled == ShouldBeEnabled::Yes
            Which is: false
        
        
        /Volumes/Data/worker/Apple-Ventura-Debug-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:7913
        Expected equality of these values:
          runJSCheck("!!window.CSSCounterStyleRule"_s)
            Which is: true
          shouldBeEnabled == ShouldBeEnabled::Yes
            Which is: false
        
        
        /Volumes/Data/worker/Apple-Ventura-Debug-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:7913
        Expected equality of these values:
          runJSCheck("!!window.CSSCounterStyleRule"_s)
            Which is: true
          shouldBeEnabled == ShouldBeEnabled::Yes
            Which is: false
        
    TestWebKitAPI.ProcessSwap.NavigatingToLockdownMode
        ERROR: Error while launching com.apple.WebKit.Networking: Connection invalid
        /Volumes/Data/worker/Apple-Ventura-Debug-Build/build/Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm(213) : auto WebKit::ProcessLauncher::launchProcess()::(anonymous class)::operator()(xpc_object_t) const
        LEAK: 1 WebProcessPool
        
        /Volumes/Data/worker/Apple-Ventura-Debug-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:7913
        Expected equality of these values:
          runJSCheck("!!window.CSSCounterStyleRule"_s)
            Which is: true
          shouldBeEnabled == ShouldBeEnabled::Yes
            Which is: false

https://results.webkit.org/?suite=api-tests&suite=api-tests&test=TestWebKitAPI.ProcessSwap.CannotDisableLockdownModeWithoutBrowserEntitlement&test=TestWebKitAPI.ProcessSwap.NavigatingToLockdownMode
Comment 1 Radar WebKit Bug Importer 2023-03-04 09:32:37 PST 
<rdar://problem/106235827>
Comment 2 Brent Fulgham 2023-03-04 10:46:28 PST 
We need to correct the expectations here now that the feature is expected to be on.
Comment 3 Brent Fulgham 2023-03-04 13:27:33 PST 
Pull request: https://github.com/Webkit/WebKit/pull/11071
Comment 4 EWS 2023-03-04 14:42:54 PST 
Committed 261231@main (93ddd026548d): <https://commits.webkit.org/261231@main>

Reviewed commits have been landed. Closing PR #11071 and removing active labels.