RESOLVED FIXED253403
Remove deadcode from SVGResourcesCache::clientStyleChanged 
https://bugs.webkit.org/show_bug.cgi?id=253403
Summary Remove deadcode from SVGResourcesCache::clientStyleChanged
Ahmad Saleem
Reported 2023-03-04 18:18:58 PST
Hi Team, While going through Blink's commits, I came across another potential merge: Blink Commit - https://chromium.googlesource.com/chromium/blink/+/3dbb235c9806036ecd531aa4eeae7ed1c4be89a7 WebKit Source Code - https://searchfox.org/wubkat/source/Source/WebCore/rendering/svg/SVGResourcesCache.cpp#169 ^ Remove this IF condition and add these ASSERT at start of function: ASSERT(renderer); ASSERT(renderer.element()); ASSERT(renderer.element()->isSVGElement()); _____ Just wanted to raise to get insight. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-03-11 18:19:14 PST
<rdar://problem/106605841>
Ahmad Saleem
Comment 2 2023-03-14 14:58:08 PDT
I tried in following PR - https://github.com/WebKit/WebKit/pull/11360 This leads to multiple test crashes on 'mac-AS-debug-wk2' instance. Closing PR to investigate, what could be issue.
Rob Buis
Comment 3 2023-10-16 03:19:22 PDT
Pull request: https://github.com/WebKit/WebKit/pull/19110
Rob Buis
Comment 4 2023-10-16 04:51:39 PDT
(In reply to Ahmad Saleem from comment #2) > I tried in following PR - https://github.com/WebKit/WebKit/pull/11360 > > This leads to multiple test crashes on 'mac-AS-debug-wk2' instance. > > Closing PR to investigate, what could be issue. My new PR seems to work, possibly the crashes were due to the ASSERT not taking into account anonymous renderers.
EWS
Comment 5 2023-10-19 06:12:19 PDT
Committed 269518@main (cd8b6c24eddd): <https://commits.webkit.org/269518@main> Reviewed commits have been landed. Closing PR #19110 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.