Bug 253451 - [ews] block-pull-request should indicate in UI the reason for being skipped.
Summary: [ews] block-pull-request should indicate in UI the reason for being skipped.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-06 11:15 PST by Aakash Jain
Modified: 2023-03-08 11:18 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2023-03-06 11:15:37 PST 
block-pull-request should indicate in UI the reason for being skipped. It has happenned few times that people asked why was block-pull-request step skipped.
Comment 1 Aakash Jain 2023-03-06 11:17:40 PST 
Pull request: https://github.com/WebKit/WebKit/pull/11123
Comment 2 EWS 2023-03-06 11:39:46 PST 
Committed 261287@main (89117ea44ecc): <https://commits.webkit.org/261287@main>

Reviewed commits have been landed. Closing PR #11123 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-03-06 11:40:16 PST 
<rdar://problem/106310256>
Comment 4 Aakash Jain 2023-03-08 11:18:09 PST 
This logging is working as expected.
e.g.: In https://ews-build.webkit.org/#/builders/12/builds/120226 `block-pull-request` step was skipped, and there was logging indicating the reason.