WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
253455
Fix SIMD global get and set in BBQ JIT
https://bugs.webkit.org/show_bug.cgi?id=253455
Summary
Fix SIMD global get and set in BBQ JIT
David Degazio
Reported
2023-03-06 12:29:15 PST
rdar://106293111
The current implementation for global.get and global.set in BBQ JIT uses the same helper to emit type-correct load and store instructions as the rest of the WASM load and store ops. SIMD load ops aren't included in these instructions though, so whenever we try to get or set a v128 global with portable binding mode, we hit an ASSERT_NOT_REACHED.
Attachments
Add attachment
proposed patch, testcase, etc.
David Degazio
Comment 1
2023-03-06 13:07:42 PST
Pull request:
https://github.com/WebKit/WebKit/pull/11126
EWS
Comment 2
2023-03-06 17:03:02 PST
Committed
261299@main
(c6d7e1b115e0): <
https://commits.webkit.org/261299@main
> Reviewed commits have been landed. Closing PR #11126 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug