Bug 253455 - Fix SIMD global get and set in BBQ JIT
Summary: Fix SIMD global get and set in BBQ JIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Degazio
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-06 12:29 PST by David Degazio
Modified: 2023-03-06 17:03 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Degazio 2023-03-06 12:29:15 PST 
rdar://106293111

The current implementation for global.get and global.set in BBQ JIT uses the same helper to emit type-correct load and store instructions as the rest of the WASM load and store ops. SIMD load ops aren't included in these instructions though, so whenever we try to get or set a v128 global with portable binding mode, we hit an ASSERT_NOT_REACHED.
Comment 1 David Degazio 2023-03-06 13:07:42 PST 
Pull request: https://github.com/WebKit/WebKit/pull/11126
Comment 2 EWS 2023-03-06 17:03:02 PST 
Committed 261299@main (c6d7e1b115e0): <https://commits.webkit.org/261299@main>

Reviewed commits have been landed. Closing PR #11126 and removing active labels.