WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
253457
Correctly discard stack values when adding else to unreachable in BBQ JIT
https://bugs.webkit.org/show_bug.cgi?id=253457
Summary
Correctly discard stack values when adding else to unreachable in BBQ JIT
David Degazio
Reported
2023-03-06 13:44:38 PST
rdar://106292162
Currently in BBQ JIT, when we end an unreachable block with an else, we don't actually flush any values to the stack or prepare to enter another block, since that code cannot be entered and thus can never pass valid results to a successor. But, we do need to make sure we correctly destroy all the values on the stack before starting to generate the else, in order to restore the correct state of the register allocator.
Attachments
Add attachment
proposed patch, testcase, etc.
David Degazio
Comment 1
2023-03-06 13:58:06 PST
Pull request:
https://github.com/WebKit/WebKit/pull/11130
EWS
Comment 2
2023-03-06 19:05:41 PST
Committed
261304@main
(95d4c84bd6e9): <
https://commits.webkit.org/261304@main
> Reviewed commits have been landed. Closing PR #11130 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug