RESOLVED FIXED253530
Fix flushing constants to StackArguments in WasmBBQJIT 
https://bugs.webkit.org/show_bug.cgi?id=253530
Summary Fix flushing constants to StackArguments in WasmBBQJIT
David Degazio
Reported 2023-03-07 13:47:38 PST
rdar://106358707 The WASM BBQ JIT currently runs into some assertion failures when flushing constant values at the end of a block. This seems to be due to the fact that emitMoveConst checks specifically if the destination is a stack slot or global, and assumes it's a register otherwise. This breaks when we wind up with a constant bound to a StackArgument location (sp-relative, v.s. fp-relative for normal stack slots).
Attachments
Add attachment proposed patch, testcase, etc.
David Degazio
Comment 1 2023-03-07 15:28:58 PST
Pull request: https://github.com/WebKit/WebKit/pull/11195
EWS
Comment 2 2023-03-07 21:38:17 PST
Committed 261358@main (65f37957e271): <https://commits.webkit.org/261358@main> Reviewed commits have been landed. Closing PR #11195 and removing active labels.
Diego Pino
Comment 3 2023-03-09 15:40:15 PST
Re-opening for pull request https://github.com/webkit/webkit/pull/11330
EWS
Comment 4 2023-03-09 17:21:35 PST
Committed 261480@main (45c0db167f82): <https://commits.webkit.org/261480@main> Reviewed commits have been landed. Closing PR #11330 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.