Bug 253530 - Fix flushing constants to StackArguments in WasmBBQJIT
Summary: Fix flushing constants to StackArguments in WasmBBQJIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-07 13:47 PST by David Degazio
Modified: 2023-03-09 17:21 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Degazio 2023-03-07 13:47:38 PST 
rdar://106358707

The WASM BBQ JIT currently runs into some assertion failures when flushing constant values at the end of a block. This seems to be due to the fact that emitMoveConst checks specifically if the destination is a stack slot or global, and assumes it's a register otherwise. This breaks when we wind up with a constant bound to a StackArgument location (sp-relative, v.s. fp-relative for normal stack slots).
Comment 1 David Degazio 2023-03-07 15:28:58 PST 
Pull request: https://github.com/WebKit/WebKit/pull/11195
Comment 2 EWS 2023-03-07 21:38:17 PST 
Committed 261358@main (65f37957e271): <https://commits.webkit.org/261358@main>

Reviewed commits have been landed. Closing PR #11195 and removing active labels.
Comment 3 Diego Pino 2023-03-09 15:40:15 PST 
Re-opening for pull request https://github.com/webkit/webkit/pull/11330
Comment 4 EWS 2023-03-09 17:21:35 PST 
Committed 261480@main (45c0db167f82): <https://commits.webkit.org/261480@main>

Reviewed commits have been landed. Closing PR #11330 and removing active labels.