Bug 253554 - [UI-side compositing] Add UI process SPIs to add page banners
Summary: [UI-side compositing] Add UI process SPIs to add page banners
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Process Model (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-07 22:11 PST by Said Abou-Hallawa
Modified: 2023-03-15 11:32 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-03-07 22:11:56 PST 
The client of WKWebView will provide CALayers for the page banners. WKWebView will add them to its layer tree. Their heights will adjust the page frameRect and the page contentSize. Mini browser will create two dummy CALayers and call the WKWebView SPI when the Setting: "Reserve Space For Banners" is checked.
Comment 1 Said Abou-Hallawa 2023-03-07 22:12:27 PST 
rdar://101040993
Comment 2 Said Abou-Hallawa 2023-03-07 22:20:50 PST 
Pull request: https://github.com/WebKit/WebKit/pull/11215
Comment 3 EWS 2023-03-13 16:09:31 PDT 
Committed 261597@main (16b186659066): <https://commits.webkit.org/261597@main>

Reviewed commits have been landed. Closing PR #11215 and removing active labels.