Bug 253566 - [AutoInstall] updates to implicit_deps don't get applied
Summary: [AutoInstall] updates to implicit_deps don't get applied
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-08 08:01 PST by Sam Sneddon [:gsnedders]
Modified: 2023-03-14 09:35 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2023-03-08 08:01:03 PST 
Currently we have:

    AutoInstall.register(Package('pytest_asyncio', Version(0, 20, 3), pypi_name='pytest-asyncio'))
    AutoInstall.register(Package('pytest_timeout', Version(2, 1, 0), pypi_name='pytest-timeout'))
    AutoInstall.register(Package('pytest', Version(7, 2, 0), implicit_deps=['pytest_asyncio', 'pytest_timeout']))

If I downgrade pytest_asyncio to 0.18.3, importing `pytest` isn't enough to trigger a re-install, despite a change in its implicit_deps.
Comment 1 Sam Sneddon [:gsnedders] 2023-03-08 08:09:33 PST 
Pull request: https://github.com/WebKit/WebKit/pull/11226
Comment 2 EWS 2023-03-08 08:25:38 PST 
Committed 261370@main (0505ac5005b9): <https://commits.webkit.org/261370@main>

Reviewed commits have been landed. Closing PR #11226 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-03-08 08:26:16 PST 
<rdar://problem/106428885>
Comment 4 EWS 2023-03-14 09:35:51 PDT 
Committed 259548.410@safari-7615-branch (b5b8a1c83775): <https://commits.webkit.org/259548.410@safari-7615-branch>

Reviewed commits have been landed. Closing PR #451 and removing active labels.