RESOLVED FIXED253601
Improve build time by reducing includes of GraphicsLayer.h 
https://bugs.webkit.org/show_bug.cgi?id=253601
Summary Improve build time by reducing includes of GraphicsLayer.h
Brent Fulgham
Reported 2023-03-08 13:38:51 PST
Benchmarking indicates that WebPage.h and WebPageProxy.h are expensive: 976056 ms: /Users/bfulgham/Projects/WebKit/OpenSource/Source/WebKit/UIProcess/WebPageProxy.h (included 78 times, avg 12513 ms), included via: 726039 ms: /Users/bfulgham/Projects/WebKit/OpenSource/Source/WebKit/WebProcess/WebPage/WebPage.h (included 60 times, avg 12100 ms), included via: Code review shows that they are included in many places they are not needed, and that they include expensive headers that increase build time. This patch improves build times by resolving some of these cases.
Attachments
Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2023-03-08 14:33:03 PST
WebPage.h drops from 12.1 seconds to about 7.4 seconds
Radar WebKit Bug Importer
Comment 2 2023-03-08 14:38:00 PST
<rdar://problem/106453112>
Brent Fulgham
Comment 3 2023-03-08 14:40:44 PST
Pull request: https://github.com/WebKit/WebKit/pull/11258
Brent Fulgham
Comment 4 2023-03-08 16:23:26 PST
Pull request: https://github.com/Webkit/WebKit/pull/11258
Brent Fulgham
Comment 5 2023-03-08 22:04:04 PST
Current PR: Original Build (M1 Pro) **** Time summary: Compilation (10257 times): Parsing (frontend): 8924.2 s Codegen & opts (backend): 3158.1 s Revised Build (M1 Pro) **** Time summary: Compilation (10188 times): Parsing (frontend): 8529.2 s Codegen & opts (backend): 3150.0 s
Brent Fulgham
Comment 6 2023-03-13 13:33:20 PDT
I split this into a second patch: Bug 253837
EWS
Comment 7 2023-03-20 16:58:03 PDT
Committed 261897@main (308d27ada88a): <https://commits.webkit.org/261897@main> Reviewed commits have been landed. Closing PR #11258 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.