WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
253604
Fix signpost persistence defaults
https://bugs.webkit.org/show_bug.cgi?id=253604
Summary
Fix signpost persistence defaults
Ben Nham
Reported
2023-03-08 14:24:27 PST
In
253387@main
I enabled signposts when tracing tools are enabled and also tried to make signpost persistence enabled by default. However the default wasn't correct since the plist I committed mapped `Signpost-Persisted` to the integer value `1`. It turns out that libtrace expects that `Signpost-Persisted` must be a boolean value, so signpost persistence wasn't actually enabled by default.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-03-08 14:25:05 PST
<
rdar://problem/106452342
>
Ben Nham
Comment 2
2023-03-08 14:27:21 PST
Pull request:
https://github.com/WebKit/WebKit/pull/11256
EWS
Comment 3
2023-03-09 22:04:20 PST
Committed
261488@main
(89dc203c7790): <
https://commits.webkit.org/261488@main
> Reviewed commits have been landed. Closing PR #11256 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug