Bug 253604 - Fix signpost persistence defaults
Summary: Fix signpost persistence defaults
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-08 14:24 PST by Ben Nham
Modified: 2023-03-09 22:04 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2023-03-08 14:24:27 PST 
In 253387@main I enabled signposts when tracing tools are enabled and also tried to make signpost persistence enabled by default. However the default wasn't correct since the plist I committed mapped `Signpost-Persisted` to the integer value `1`. It turns out that libtrace expects that `Signpost-Persisted` must be a boolean value, so signpost persistence wasn't actually enabled by default.
Comment 1 Radar WebKit Bug Importer 2023-03-08 14:25:05 PST 
<rdar://problem/106452342>
Comment 2 Ben Nham 2023-03-08 14:27:21 PST 
Pull request: https://github.com/WebKit/WebKit/pull/11256
Comment 3 EWS 2023-03-09 22:04:20 PST 
Committed 261488@main (89dc203c7790): <https://commits.webkit.org/261488@main>

Reviewed commits have been landed. Closing PR #11256 and removing active labels.