RESOLVED FIXED253612
AX: Stop caching 9 isolated object properties unnecessarily 
https://bugs.webkit.org/show_bug.cgi?id=253612
Summary AX: Stop caching 9 isolated object properties unnecessarily
Tyler Wilcock
Reported 2023-03-08 15:46:01 PST
We have many properties that can be expressed purely in terms of AXCoreObject methods.
Attachments
Patch (35.14 KB, patch)
2023-03-08 15:52 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (35.22 KB, patch)
2023-03-09 10:26 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-03-08 15:46:12 PST
<rdar://problem/106456887>
Tyler Wilcock
Comment 2 2023-03-08 15:52:15 PST
Created attachment 465365 [details] Patch
chris fleizach
Comment 3 2023-03-08 16:03:54 PST
Comment on attachment 465365 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=465365&action=review did you measure any improvements from this one? > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:-1054 > - AXCoreObject::AccessibilityChildrenVector tabs; how come we don't need this?
Tyler Wilcock
Comment 4 2023-03-08 16:05:45 PST
(In reply to chris fleizach from comment #3) > Comment on attachment 465365 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=465365&action=review > > did you measure any improvements from this one? > > > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:-1054 > > - AXCoreObject::AccessibilityChildrenVector tabs; > > how come we don't need this? The code builds `tabs` but never uses it, so I believe this is just wasted work unless you know of some reason to do this.
chris fleizach
Comment 5 2023-03-08 16:36:39 PST
Comment on attachment 465365 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=465365&action=review >>> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:-1054 >>> - AXCoreObject::AccessibilityChildrenVector tabs; >> >> how come we don't need this? > > The code builds `tabs` but never uses it, so I believe this is just wasted work unless you know of some reason to do this. does tabChildren do some work in the background?
Tyler Wilcock
Comment 6 2023-03-08 17:53:18 PST
(In reply to chris fleizach from comment #5) > Comment on attachment 465365 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=465365&action=review > > >>> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:-1054 > >>> - AXCoreObject::AccessibilityChildrenVector tabs; > >> > >> how come we don't need this? > > > > The code builds `tabs` but never uses it, so I believe this is just wasted work unless you know of some reason to do this. > > does tabChildren do some work in the background? The only side-effect it could have is calling AXCoreObject::children(updateChildrenIfNecessary = true), but I don't think that side-effect is needed here (and if it were, a comment should be added, and a test should fail if the side effect is removed).
Tyler Wilcock
Comment 7 2023-03-09 10:26:48 PST
Created attachment 465377 [details] Patch
EWS
Comment 8 2023-03-10 00:20:34 PST
commit-queue failed to commit attachment 465377 [details] to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 9 2023-03-10 10:27:30 PST
Committed 261508@main (ae20ce99baa2): <https://commits.webkit.org/261508@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465377 [details].
Note You need to log in before you can comment on or make changes to this bug.