We have many properties that can be expressed purely in terms of AXCoreObject methods.
<rdar://problem/106456887>
Created attachment 465365 [details] Patch
Comment on attachment 465365 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=465365&action=review did you measure any improvements from this one? > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:-1054 > - AXCoreObject::AccessibilityChildrenVector tabs; how come we don't need this?
(In reply to chris fleizach from comment #3) > Comment on attachment 465365 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=465365&action=review > > did you measure any improvements from this one? > > > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:-1054 > > - AXCoreObject::AccessibilityChildrenVector tabs; > > how come we don't need this? The code builds `tabs` but never uses it, so I believe this is just wasted work unless you know of some reason to do this.
Comment on attachment 465365 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=465365&action=review >>> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:-1054 >>> - AXCoreObject::AccessibilityChildrenVector tabs; >> >> how come we don't need this? > > The code builds `tabs` but never uses it, so I believe this is just wasted work unless you know of some reason to do this. does tabChildren do some work in the background?
(In reply to chris fleizach from comment #5) > Comment on attachment 465365 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=465365&action=review > > >>> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:-1054 > >>> - AXCoreObject::AccessibilityChildrenVector tabs; > >> > >> how come we don't need this? > > > > The code builds `tabs` but never uses it, so I believe this is just wasted work unless you know of some reason to do this. > > does tabChildren do some work in the background? The only side-effect it could have is calling AXCoreObject::children(updateChildrenIfNecessary = true), but I don't think that side-effect is needed here (and if it were, a comment should be added, and a test should fail if the side effect is removed).
Created attachment 465377 [details] Patch
commit-queue failed to commit attachment 465377 [details] to WebKit repository. To retry, please set cq+ flag again.
Committed 261508@main (ae20ce99baa2): <https://commits.webkit.org/261508@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465377 [details].