Bug 253618 - [WebAssembly] Fix tests and build on x86-64 Linux with BBQJIT
Summary: [WebAssembly] Fix tests and build on x86-64 Linux with BBQJIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 253501 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-03-08 18:03 PST by Asumu Takikawa
Modified: 2023-03-09 10:34 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Asumu Takikawa 2023-03-08 18:03:20 PST 
Currently on x86-64 Linux configs, many Wasm tests seem to be failing on various test configurations, e.g., for SIMD. Here's an example that crashes:

`~/WebKit/JSTests/wasm/modules$ /WebKit/WebKitBuild/Debug/bin/jsc --useWebAssemblySIMD=1 --forceAllFunctionsToUseSIMD=1 --useSinglePassBBQJIT=true -m run-from-wasm.wasm`

Setting single pass to false makes it stop crashing. The problem seems to be that the single pass BBQ JIT is enabled in the options, but it's not configured to be built in the build setup (which means the BBQJIT code is not compiled, and the crash happens due to missing initialization of compilation contexts).
Comment 1 Asumu Takikawa 2023-03-08 18:07:42 PST 
Pull request: https://github.com/WebKit/WebKit/pull/11268
Comment 2 EWS 2023-03-09 01:33:57 PST 
Committed 261417@main (361c5fba483c): <https://commits.webkit.org/261417@main>

Reviewed commits have been landed. Closing PR #11268 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-03-09 01:34:18 PST 
<rdar://problem/106490154>
Comment 4 Michael Catanzaro 2023-03-09 10:34:08 PST 
*** Bug 253501 has been marked as a duplicate of this bug. ***