Bug 253629 - Use a WeakPtr for InlineCSSStyleDeclaration::m_parentElement
Summary: Use a WeakPtr for InlineCSSStyleDeclaration::m_parentElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-08 22:06 PST by Chris Dumez
Modified: 2023-03-10 11:41 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-03-08 22:06:04 PST 
Use a WeakPtr for InlineCSSStyleDeclaration::m_parentElement. This is safer than keeping a raw pointer and avoids some work in the StyleElement destructor to clear this pointer.
Comment 1 Chris Dumez 2023-03-08 22:07:34 PST 
Pull request: https://github.com/WebKit/WebKit/pull/11283
Comment 2 EWS 2023-03-09 08:50:43 PST 
Committed 261440@main (a08f9d20cd53): <https://commits.webkit.org/261440@main>

Reviewed commits have been landed. Closing PR #11283 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-03-09 08:51:17 PST 
<rdar://problem/106502986>
Comment 4 Chris Dumez 2023-03-09 14:59:15 PST 
Reverted by https://github.com/WebKit/WebKit/pull/11328
Comment 5 Chris Dumez 2023-03-09 14:59:16 PST 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/11328
Comment 6 EWS 2023-03-09 15:16:24 PST 
Committed 261475@main (7b7bf746e7bc): <https://commits.webkit.org/261475@main>

Reviewed commits have been landed. Closing PR #11328 and removing active labels.
Comment 7 Chris Dumez 2023-03-10 09:04:41 PST 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/11365
Comment 8 EWS 2023-03-10 11:41:50 PST 
Committed 261517@main (bbcee9c23927): <https://commits.webkit.org/261517@main>

Reviewed commits have been landed. Closing PR #11365 and removing active labels.