Bug 253668 - [ iOS ] imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic.html
Summary: [ iOS ] imported/w3c/web-platform-tests/html/semantics/popovers/popover-attri...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bri Harris
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-09 12:36 PST by Bri Harris
Modified: 2023-03-09 16:37 PST (History)
3 users (show)

See Also:


Attachments
Diff Text (77.70 KB, text/plain)
2023-03-09 12:36 PST, Bri Harris
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bri Harris 2023-03-09 12:36:29 PST
Created attachment 465379 [details]
Diff Text

imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic.html 

is a constant failure on iOS 16. 



HISTORY:

https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fsemantics%2Fpopovers%2Fpopover-attribute-basic.html


Diff Text is attached.
Comment 1 Radar WebKit Bug Importer 2023-03-09 12:36:45 PST
<rdar://problem/106515368>
Comment 2 Bri Harris 2023-03-09 13:11:51 PST
I was able to replicate this failure on iOS 16 ToT as follows:

run-webkit-tests imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic.html
Comment 3 Ryan Haddad 2023-03-09 14:33:13 PST
https://commits.webkit.org/261386@main rebaselined the test, but there is also an ios-wk2 specific baseline that wasn't modified. 

We should compare the generic baseline to the actual output on iOS to see if we just need to rebaseline it there too.
Comment 4 Bri Harris 2023-03-09 16:06:58 PST
Pull request: https://github.com/WebKit/WebKit/pull/11334
Comment 5 EWS 2023-03-09 16:15:07 PST
Test gardening commit 261477@main (268be348f38b): <https://commits.webkit.org/261477@main>

Reviewed commits have been landed. Closing PR #11334 and removing active labels.
Comment 6 Bri Harris 2023-03-09 16:24:15 PST
(In reply to Ryan Haddad from comment #3)
> https://commits.webkit.org/261386@main rebaselined the test, but there is
> also an ios-wk2 specific baseline that wasn't modified. 
> 
> We should compare the generic baseline to the actual output on iOS to see if
> we just need to rebaseline it there too.

This made sense! I did a rebaseline locally and verified it was passing after. I'll monitor to make sure it's passing before closing this out.