RESOLVED FIXED253723
REGRESSION(261329@main): inspector/css/modify-css-property.html(layout-tests) is a constant crash 
https://bugs.webkit.org/show_bug.cgi?id=253723
Summary REGRESSION(261329@main): inspector/css/modify-css-property.html(layout-tests)...
Dawn Morningstar
Reported 2023-03-10 10:55:26 PST
inspector/css/modify-css-property.html is a constant crash on macOS queues after261329@main http://commits.webkit.org/261329@main HISTORY: https://results.webkit.org/?suite=layout-tests&test=inspector%2Fcss%2Fmodify-css-property.html This test is crashing but it seems unable to generate a crash-log. Instead it says: No crash log found for DumpRenderTree:50556. I'll do my best to get one and add it here as a comment.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-03-10 10:57:31 PST
<rdar://problem/106561354>
Dawn Morningstar
Comment 2 2023-03-10 11:00:23 PST
Continuing to investigate and attempting to grab crash log but assigning to Patrick whom made the commit.
Ryan Haddad
Comment 3 2023-03-10 11:49:56 PST
ASSERTION FAILED: is<Target>(source) /Volumes/Data/worker/Apple-Ventura-Debug-Build/build/WebKitBuild/Debug/usr/local/include/wtf/TypeCasts.h(79) : match_constness_t<Source, Target> &WTF::downcast(Source &) [Target = WebCore::StyleRule, Source = WebCore::StyleRuleBase] 1 0x32c282c39 WTFCrash 2 0x32c282c59 WTFCrashWithSecurityImplication 3 0x2eec2e971 std::__1::conditional<std::is_const_v<WebCore::StyleRuleBase>, std::__1::add_const<WebCore::StyleRule>::type, std::__1::remove_const<WebCore::StyleRule>::type>::type& WTF::downcast<WebCore::StyleRule, WebCore::StyleRuleBase>(WebCore::StyleRuleBase&) 4 0x2eec2e8c1 WebCore::CSSStyleRule::reattach(WebCore::StyleRuleBase&) 5 0x2eec30257 WebCore::CSSStyleSheet::reattachChildRuleCSSOMWrappers() 6 0x2eec30070 WebCore::CSSStyleSheet::willMutateRules() 7 0x2eec333ab WebCore::CSSStyleSheet::RuleMutationScope::RuleMutationScope(WebCore::CSSStyleSheet*, WebCore::CSSStyleSheet::RuleMutationType, WebCore::StyleRuleKeyframes*) 8 0x2eec319cb WebCore::CSSStyleSheet::RuleMutationScope::RuleMutationScope(WebCore::CSSStyleSheet*, WebCore::CSSStyleSheet::RuleMutationType, WebCore::StyleRuleKeyframes*) 9 0x2efb23a73 WebCore::InspectorStyleSheet::reparseStyleSheet(WTF::String const&) 10 0x2efb28e5e WebCore::InspectorStyleSheet::setRuleStyleText(WebCore::InspectorCSSId const&, WTF::String const&, WTF::String*, WebCore::InspectorStyleSheet::IsUndo)::$_22::operator()(WTF::String&) const 11 0x2efb28d6e WebCore::InspectorStyleSheet::setRuleStyleText(WebCore::InspectorCSSId const&, WTF::String const&, WTF::String*, WebCore::InspectorStyleSheet::IsUndo) 12 0x2efbce082 WebCore::InspectorCSSAgent::SetStyleTextAction::redo()
Patrick Angle
Comment 4 2023-03-10 13:14:01 PST
I wonder if a CSS change and I crossed paths here... The pre-commit bots were green at the time of landing.
Matthieu Dubet
Comment 5 2023-03-17 13:14:33 PDT
Pull request: https://github.com/WebKit/WebKit/pull/11663
EWS
Comment 6 2023-03-17 17:50:03 PDT
Committed 261815@main (1274b2e85784): <https://commits.webkit.org/261815@main> Reviewed commits have been landed. Closing PR #11663 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.