Bug 253736 - V8 huge memory tests for WASM should be skipped on memory limited platforms
Summary: V8 huge memory tests for WASM should be skipped on memory limited platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Degazio
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-10 14:25 PST by David Degazio
Modified: 2023-03-13 11:09 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Degazio 2023-03-10 14:25:06 PST 
rdar://106216553

The following V8 WASM tests:

 - grow-huge-memory.js
 - huge-memory.js
 - huge-typedarray.js

are designed to test that WASM memories larger than 2GB are correctly supported. We pass this reliably on most platforms. However, some of our test runners are memory limited, and simply don't have enough available memory to allocate the WASM memory, instead failing with an OOM. We should skip these tests on memory limited platforms, consistent with existing JS stress tests that allocate large (>10MB) arrays and buffers.
Comment 1 David Degazio 2023-03-10 14:28:47 PST 
Pull request: https://github.com/WebKit/WebKit/pull/11384
Comment 2 EWS 2023-03-13 11:09:07 PDT 
Committed 261577@main (d12810b70871): <https://commits.webkit.org/261577@main>

Reviewed commits have been landed. Closing PR #11384 and removing active labels.