Bug 253749 - github.com is broken
Summary: github.com is broken
Status: RESOLVED DUPLICATE of bug 211979
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-10 19:05 PST by Kdwk
Modified: 2023-03-11 10:35 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kdwk 2023-03-10 19:05:39 PST 
Navigating to github.com on Epiphany Tech Preview results in a white page.

Epiphany Tech Preview 44.rc-19-ga80fcd0ab+, WebKitGTK 2.39.91
Comment 1 Xi Ruoyao 2023-03-11 06:17:43 PST 
I've reported https://github.com/orgs/community/discussions/49755.
Comment 2 Michael Catanzaro 2023-03-11 06:40:25 PST 
Time for a mandatory break from WebKit development. :P Cannot view that discussion or any pull requests.

Interestingly, it does work if I use Epiphany 43 with WebKitGTK 2.38 for whatever reason, so I can see the problem is we're missing navigator.clipboard.read.
Comment 3 Michael Catanzaro 2023-03-11 06:51:51 PST 
(In reply to Michael Catanzaro from comment #2)
> Interestingly, it does work if I use Epiphany 43 with WebKitGTK 2.38 for
> whatever reason

Ah no, I just got unlucky. It's broken in both versions but sometimes the page content displays anyway.
Comment 4 Michael Catanzaro 2023-03-11 06:59:51 PST 
This is the missing API:

# FIXME: This is on by default in WebKit2 PLATFORM(COCOA). Perhaps we should consider turning it on for WebKitLegacy as well.
AsyncClipboardAPIEnabled:
  type: bool
  status: mature
  humanReadableName: "Async clipboard API"
  humanReadableDescription: "Enable the async clipboard API"
  defaultValue:
    WebKitLegacy:
      default: false
    WebKit:
      "PLATFORM(COCOA)" : true
      default: false
    WebCore:
      default: false

I'm surprised this sort of breakage does not happen more often since we're not very good at keeping up with new web APIs.

It looks like the implementation in Source/WebCore/Modules/async-clipboard is entirely cross-platform (build on top of our existing clipboard platform abstractions) and the only platform-specific bits are the image reader, so... maybe we can just turn it on.
Comment 5 Xi Ruoyao 2023-03-11 07:03:03 PST 
(In reply to Michael Catanzaro from comment #4)
> This is the missing API:
> 
> # FIXME: This is on by default in WebKit2 PLATFORM(COCOA). Perhaps we should
> consider turning it on for WebKitLegacy as well.
> AsyncClipboardAPIEnabled:
>   type: bool
>   status: mature
>   humanReadableName: "Async clipboard API"
>   humanReadableDescription: "Enable the async clipboard API"
>   defaultValue:
>     WebKitLegacy:
>       default: false
>     WebKit:
>       "PLATFORM(COCOA)" : true
>       default: false
>     WebCore:
>       default: false
> 
> I'm surprised this sort of breakage does not happen more often since we're
> not very good at keeping up with new web APIs.
> 
> It looks like the implementation in Source/WebCore/Modules/async-clipboard
> is entirely cross-platform (build on top of our existing clipboard platform
> abstractions) and the only platform-specific bits are the image reader,
> so... maybe we can just turn it on.

Even if we don't turn it on, I think GitHub developers should not make a dead loop in the JavaScript code...
Comment 6 Michael Catanzaro 2023-03-11 10:35:56 PST 

*** This bug has been marked as a duplicate of bug 211979 ***