Bug 253765 - Update Document::m_ranges to be a WeakHashSet
Summary: Update Document::m_ranges to be a WeakHashSet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 253875
Blocks:
  Show dependency tree / graph
 
Reported: 2023-03-11 15:57 PST by Chris Dumez
Modified: 2023-03-14 14:04 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-03-11 15:57:08 PST 
Update Document::m_ranges to be a WeakHashSet.
Comment 1 Chris Dumez 2023-03-11 15:58:51 PST 
Pull request: https://github.com/WebKit/WebKit/pull/11407
Comment 2 EWS 2023-03-13 13:30:51 PDT 
Committed 261586@main (a526a939ab0c): <https://commits.webkit.org/261586@main>

Reviewed commits have been landed. Closing PR #11407 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-03-13 13:31:16 PDT 
<rdar://problem/106660404>
Comment 4 Fujii Hironori 2023-03-14 00:31:22 PDT 
The assertion is randomly crashing.

> ASSERTION FAILED: m_ranges.isEmptyIgnoringNullReferences()
> dom/Document.cpp(716) : virtual WebCore::Document::~Document()

https://results.webkit.org/?suite=layout-tests&test=editing%2Fdeleting%2Fdelete-block-merge-contents-011.html
https://ews-build.webkit.org/#/builders/84/builds/9917
Comment 5 WebKit Commit Bot 2023-03-14 00:36:07 PDT 
Re-opened since this is blocked by bug 253875
Comment 6 Fujii Hironori 2023-03-14 14:04:48 PDT 
Thank you for fixing. Closed again.