Bug 253770 - Delete odd assignment of IgnoreOverlayScrollbarSize
Summary: Delete odd assignment of IgnoreOverlayScrollbarSize
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 253771 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-03-11 17:24 PST by Ahmad Saleem
Modified: 2023-03-20 13:52 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-03-11 17:24:05 PST
Hi Team,

While going through Blink's commit, I came across another potential merge and I have tested this locally on --release build and does not seem to cause any issue. Although EWS or Debug builds might have other story to tell.

NOTE - Motivation to merge is to get rid of "FIXME" and deadcode is deadcode:

____

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/bd25c52a9a4dcd09e0ed47ba300cf82e86b28cb7

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderLayer.cpp#4480

^ Removed:


            ClipRectsContext parentContext(clipRectsContext);
            parentContext.options.remove(ClipRectsOption::IncludeOverlayScrollbarSize); // FIXME: Why?
            
            if ((parentContext.clipRectsType != TemporaryClipRects && parentContext.clipRectsType != AbsoluteClipRects) && clipCrossesPaintingBoundary())
                parentContext.clipRectsType = TemporaryClipRects;

_____

Replaced:

parentLayer->calculateClipRects(parentContext, clipRects);

with

parentLayer->calculateClipRects(clipRectsContext, clipRects);

____

Just wanted to raise to get input.

Thanks!
Comment 1 Ahmad Saleem 2023-03-11 18:36:51 PST
*** Bug 253771 has been marked as a duplicate of this bug. ***
Comment 2 Radar WebKit Bug Importer 2023-03-18 18:25:16 PDT
<rdar://problem/106904250>
Comment 3 Simon Fraser (smfr) 2023-03-20 13:52:43 PDT
That "ignore overlay scrollbar size" came from bug 91117.