WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 253770
253771
Delete odd assignment of IgnoreOverlayScrollbarSize
https://bugs.webkit.org/show_bug.cgi?id=253771
Summary
Delete odd assignment of IgnoreOverlayScrollbarSize
Ahmad Saleem
Reported
2023-03-11 17:25:08 PST
Hi Team, While going through Blink's commit, I came across another potential merge and I have tested this locally on --release build and does not seem to cause any issue. Although EWS or Debug builds might have other story to tell. NOTE - Motivation to merge is to get rid of "FIXME" and deadcode is deadcode: ____ Blink Commit -
https://chromium.googlesource.com/chromium/blink/+/bd25c52a9a4dcd09e0ed47ba300cf82e86b28cb7
WebKit Source -
https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderLayer.cpp#4480
^ Removed: ClipRectsContext parentContext(clipRectsContext); parentContext.options.remove(ClipRectsOption::IncludeOverlayScrollbarSize); // FIXME: Why? if ((parentContext.clipRectsType != TemporaryClipRects && parentContext.clipRectsType != AbsoluteClipRects) && clipCrossesPaintingBoundary()) parentContext.clipRectsType = TemporaryClipRects; _____ Replaced: parentLayer->calculateClipRects(parentContext, clipRects); with parentLayer->calculateClipRects(clipRectsContext, clipRects); ____ Just wanted to raise to get input. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Ahmad Saleem
Comment 1
2023-03-11 18:36:51 PST
*** This bug has been marked as a duplicate of
bug 253770
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug