RESOLVED FIXED253775
[IFC][Partial layout] Editing constructs individual renderers for "new line" when typing in textarea 
https://bugs.webkit.org/show_bug.cgi?id=253775
Summary [IFC][Partial layout] Editing constructs individual renderers for "new line" ...
alan
Reported 2023-03-11 19:53:37 PST
ssia
Attachments
Patch (9.01 KB, patch)
2023-03-11 20:09 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (12.90 KB, patch)
2023-03-11 21:27 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (14.33 KB, patch)
2023-03-12 15:53 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (14.47 KB, patch)
2023-03-13 06:45 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (14.53 KB, patch)
2023-03-13 08:21 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (14.40 KB, patch)
2023-03-17 05:56 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (15.34 KB, patch)
2023-03-18 07:44 PDT, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (15.30 KB, patch)
2023-03-18 14:52 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2023-03-11 20:09:30 PST
Created attachment 465399 [details] Patch
alan
Comment 2 2023-03-11 21:27:29 PST
Created attachment 465400 [details] Patch
Antti Koivisto
Comment 3 2023-03-12 12:12:47 PDT
--- a/Source/WebCore/layout/layouttree/LayoutElementBox.cpp +++ b/Source/WebCore/layout/layouttree/LayoutElementBox.cpp @@ -118,6 +118,29 @@ void ElementBox::appendChild(UniqueRef<Box> childRef) nextOrFirst = WTFMove(childBox); } +void ElementBox::insertChild(UniqueRef<Box> childRef, Box* beforeChild) +{ we can probably replace use of appendChild with insertChild(child, nullptr)
alan
Comment 4 2023-03-12 15:53:48 PDT
Created attachment 465407 [details] Patch
alan
Comment 5 2023-03-13 06:45:01 PDT
Created attachment 465418 [details] Patch
alan
Comment 6 2023-03-13 08:21:33 PDT
Created attachment 465421 [details] Patch
alan
Comment 7 2023-03-17 05:56:19 PDT
Created attachment 465474 [details] Patch
alan
Comment 8 2023-03-18 07:44:35 PDT
Created attachment 465491 [details] Patch
alan
Comment 9 2023-03-18 14:52:46 PDT
Created attachment 465495 [details] [fast-cq]Patch
EWS
Comment 10 2023-03-18 19:29:43 PDT
Committed 261833@main (2dbdc010d549): <https://commits.webkit.org/261833@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465495 [details].
Radar WebKit Bug Importer
Comment 11 2023-03-18 19:30:17 PDT
<rdar://problem/106904861>
Note You need to log in before you can comment on or make changes to this bug.