Bug 253812 - [Win] Remove DLLLauncherMain.cpp
Summary: [Win] Remove DLLLauncherMain.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-13 01:06 PDT by Fujii Hironori
Modified: 2023-07-06 13:00 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2023-03-13 01:06:26 PDT 
[Win] Remove DLLLauncherMain.cpp

AppleWin has gone. We no longer need DLLLauncherMain.cpp that make CMake complicated.
However, we have to set the path to WebKitLibraries/win/bin64, or copy all DLLs.

> path %WEBKIT_LIBRARIES%\bin64;%path%

I prefer the former.
WinCairo tester buildbots also have to set the path.
Comment 1 Fujii Hironori 2023-03-13 01:10:41 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11435
Comment 2 Stephan Szabo 2023-03-13 10:06:19 PDT 
It's unclear to me by what you mean by setting the path? Do you mean that the user of the binary needs to set the path? If so, I'm not convinced that's a good tradeoff, especially not without a lot more discussion involved.
Comment 3 Radar WebKit Bug Importer 2023-03-20 01:07:15 PDT 
<rdar://problem/106932734>
Comment 4 EWS 2023-07-06 13:00:20 PDT 
Committed 265819@main (21785f58f0ef): <https://commits.webkit.org/265819@main>

Reviewed commits have been landed. Closing PR #11435 and removing active labels.