Bug 253837 - Reduce some costly includes from WebPage.h
Summary: Reduce some costly includes from WebPage.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks: 253601
  Show dependency tree / graph
 
Reported: 2023-03-13 11:58 PDT by Brent Fulgham
Modified: 2023-03-16 12:29 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2023-03-13 11:58:17 PDT 
This is a subset of the mega-patch in Bug 253601.

Benchmarking shows that WebPage.h is very costly to parse due to a few heavyweight includes. We can improve build time by using more specific includes where appropriate, and forward declare classes when possible.
Comment 1 Radar WebKit Bug Importer 2023-03-13 12:01:09 PDT 
<rdar://problem/106655602>
Comment 2 Brent Fulgham 2023-03-13 12:05:22 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11451
Comment 3 Brent Fulgham 2023-03-15 09:47:17 PDT 
Pull request: https://github.com/Webkit/WebKit/pull/11451
Comment 4 EWS 2023-03-15 13:39:51 PDT 
Committed 261710@main (d59dce7984ad): <https://commits.webkit.org/261710@main>

Reviewed commits have been landed. Closing PR #11451 and removing active labels.
Comment 5 Fujii Hironori 2023-03-15 14:53:05 PDT 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/11574
Comment 6 EWS 2023-03-15 14:57:24 PDT 
Committed 261715@main (baddb1e77fcb): <https://commits.webkit.org/261715@main>

Reviewed commits have been landed. Closing PR #11574 and removing active labels.
Comment 7 Fujii Hironori 2023-03-15 15:25:02 PDT 
Hmm, GTK/WPE are still broken. WinCairo/PlayStation got back to green.
Comment 8 Brent Fulgham 2023-03-15 15:35:23 PDT 
It looks like your fix should work for WPE/GTK, too. They are complaining about Logging in debug build for the same symbols you just landed.
Comment 9 Fujii Hironori 2023-03-15 17:37:23 PDT 
Ah, you are right. I checked a wrong revision. GTK is green. WPE bot is still building.