Bug 253859 - Add additional STL things to PCH files
Summary: Add additional STL things to PCH files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-13 17:27 PDT by Brent Fulgham
Modified: 2023-03-14 10:09 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2023-03-13 17:27:39 PDT 
Flamegraphs of the build revealed a few STL headers, and one OS logging header, that are particularly costly. Adding them to our precompiled header set shows a measurable reduction in build time.

Prior to this change:
**** Time summary:
Compilation (10204 times):
  Parsing (frontend):         9250.1 s
  Codegen & opts (backend):   3311.8 s

With this change:
**** Time summary:
Compilation (10202 times):
  Parsing (frontend):         8907.4 s
  Codegen & opts (backend):   3189.9 s
Comment 1 Radar WebKit Bug Importer 2023-03-13 17:28:05 PDT 
<rdar://problem/106673843>
Comment 2 Brent Fulgham 2023-03-13 17:31:28 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11471
Comment 3 EWS 2023-03-14 10:09:47 PDT 
Committed 261636@main (25b5fe6befd0): <https://commits.webkit.org/261636@main>

Reviewed commits have been landed. Closing PR #11471 and removing active labels.