Bug 253877 - [GLib] No render update when seeking outside of network buffer in fullscreen
Summary: [GLib] No render update when seeking outside of network buffer in fullscreen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
: 254480 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-03-14 02:15 PDT by Kdwk
Modified: 2023-04-03 13:06 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kdwk 2023-03-14 02:15:36 PDT 
In YouTube videos, when seeking outside the network buffer, the whole player area (fullscreened) would sometimes not update, until manually un-fullscreening and fullscreening again.
Comment 1 Kdwk 2023-03-14 02:16:22 PDT 
Screencast showing YouTube player not updating until un-fullscreening after seeking: http://kdwk.tplinkdns.com/index.php/s/CPo3Mi6am8sHAeK
Comment 2 Kdwk 2023-03-14 02:19:31 PDT 
Tested on WebKitGTK 2.39.91, Epiphany Technology Preview 44.rc-22-gf847def6c+, GStreamer 1.20.5
Comment 3 Philippe Normand 2023-03-14 04:44:11 PDT 
Can you confirm this is specific to the VA+DMABuf sink combo?
Comment 4 Kdwk 2023-03-14 06:49:01 PDT 
Just checked. Happens with no environment variables as well (non-VA, non-DMABuf)
Comment 5 Philippe Normand 2023-03-19 07:58:37 PDT 
This is not related with GStreamer/MSE, but with Fullscreen handling, which is implemented differently in GLib vs Apple ports (those rely on ENABLE(VIDEO_PRESENTATION_MODE) which we should at some point do too...).


Anyhow... with a Chrome UA it works. Shrug.
Comment 6 Philippe Normand 2023-03-19 08:01:53 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11696
Comment 7 EWS 2023-03-19 10:16:34 PDT 
Committed 261839@main (4ad4b2d3a795): <https://commits.webkit.org/261839@main>

Reviewed commits have been landed. Closing PR #11696 and removing active labels.
Comment 8 Michael Catanzaro 2023-03-26 07:34:37 PDT 
*** Bug 254480 has been marked as a duplicate of this bug. ***
Comment 9 Michael Catanzaro 2023-03-26 07:38:36 PDT 
I wish we knew why the UA quirk affects rendering updates as that seems like something websites should not be able to break no matter what they do wrong....
Comment 10 Kdwk 2023-03-26 07:50:09 PDT 
Reporting browser as Chrome apparently also enables ‘scroll for more information’, which allows users to scroll directly to to the comments section from the fullscreened video.
Comment 11 Philippe Normand 2023-03-26 08:34:20 PDT 
(In reply to kdwkleung from comment #10)
> Reporting browser as Chrome apparently also enables ‘scroll for more
> information’, which allows users to scroll directly to to the comments
> section from the fullscreened video.

Is that considered a bug or a feature? :)
Comment 12 Kdwk 2023-03-26 20:33:49 PDT 
Feature. Chrome and Firefox also support this.
Comment 13 tri.voxel 2023-04-03 12:12:05 PDT 
I can confirm this is now fixed in the latest technology preview. Would be nice to see this land in the stable version sometime soon as this could really improve the user experience. Thanks for all the hard work, guys!
Comment 14 Michael Catanzaro 2023-04-03 13:06:51 PDT 
This is on the backports list for 2.40.1.

(That said, I repeat my warning that it's fragile and may need to be removed in the future.)