Bug 253889 - [ews-build.webkit.org] Always configure credential reader when fetching
Summary: [ews-build.webkit.org] Always configure credential reader when fetching
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
: 253847 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-03-14 08:56 PDT by Jonathan Bedard
Modified: 2023-03-14 09:21 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-03-14 08:56:19 PDT 
While fetching for security PRs requires the creential reader, committing does too. We should always configure the credential reader when fetching, even if we don't need the credential reader to fetch (because we will need it for committing)
Comment 1 Radar WebKit Bug Importer 2023-03-14 08:56:34 PDT 
<rdar://problem/106704680>
Comment 2 Jonathan Bedard 2023-03-14 08:57:51 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11497
Comment 3 EWS 2023-03-14 09:05:27 PDT 
Committed 261633@main (0df334e9989f): <https://commits.webkit.org/261633@main>

Reviewed commits have been landed. Closing PR #11497 and removing active labels.
Comment 4 Ryan Haddad 2023-03-14 09:21:58 PDT 
*** Bug 253847 has been marked as a duplicate of this bug. ***